On Sun, 14 Jan 2007 12:54:17 -0800 Brandon Barnes <winterknight@nerdshack.com> wrote: > Are we allowed to disable compiler warnings? What is the preferred > method, if the code is fine, and would require a huge overhaul to fix? Warnings are only a problem if -Werror is also set. If upstream don't use -Werror, the warnings may actually be useful in debugging the package and/or FTBFS bugs from porters. As the humble opinion of one DD, hiding any output that does not stop the build is a BadIdea(TM) in most cases - as well as being unnecessary. (Which is why I don't mind commented dh_ lines in rules but that's a different thread.) > The code for the package that I am maintaining, xevil, uses xpm files, > which, by design, are likely to give off the trigraph warning. Is it > acceptable to disable these warnings? Personally, no - with the sole proviso that -Werror is not used. i.e. that the build continues. > If so, should I disable them in > Makefile, or debian/rules? No. I would recommend leaving them in - you may be grateful for the evidence in times to come. Warnings are issued for a reason - until upstream fix the code, I'd always recommend to leave the warning in place. -- Neil Williams ============= http://www.data-freedom.org/ http://www.nosoftwarepatents.com/ http://www.linux.codehelp.co.uk/
Attachment:
pgph0A78xX7aB.pgp
Description: PGP signature