Re: RFS: atheme
On Sat, Aug 04, 2007 at 04:23:16PM +0100, Bradley Smith wrote:
> Also, since this is my first package, any comments/advice would be greatly appreciated.
Ok, I had now a more exact look at your package and there are the
following things I don't like:
Output from diffstat about the .diff.gz file:
contrib/.depend | 330 +++++++++++++++
contrib/Makefile | 89 ++++
debian/atheme-default | 11
debian/atheme-services.8 | 51 ++
debian/changelog | 7
debian/compat | 1
debian/control | 19
debian/copyright | 76 +++
debian/docs | 2
debian/init.d | 74 +++
debian/patches/00list | 2
debian/patches/01_config.dpatch | 19
debian/patches/02_binpath.dpatch | 43 ++
debian/rules | 84 ++++
debian/watch | 3
modules/backend/.depend | 17
modules/backend/Makefile | 69 +++
modules/chanserv/.depend | 578 +++++++++++++++++++++++++++
modules/chanserv/Makefile | 103 ++++
modules/crypto/.depend | 51 ++
modules/crypto/Makefile | 69 +++
modules/gameserv/.depend | 102 ++++
modules/gameserv/Makefile | 75 +++
modules/global/.depend | 17
modules/global/Makefile | 69 +++
modules/memoserv/.depend | 153 +++++++
modules/memoserv/Makefile | 79 +++
modules/nickserv/.depend | 442 +++++++++++++++++++++
modules/nickserv/Makefile | 99 ++++
modules/operserv/.depend | 476 ++++++++++++++++++++++
modules/operserv/Makefile | 97 ++++
modules/protocol/.depend | 378 ++++++++++++++++++
modules/protocol/Makefile | 90 ++++
modules/saslserv/.depend | 68 +++
modules/saslserv/Makefile | 73 +++
modules/xmlrpc/.depend | 68 +++
modules/xmlrpc/Makefile | 73 +++
po/Makefile | 600 ++++++++++++++++++++++++++++
po/Makefile.in | 403 +++++++++++++++++++
po/POTFILES | 109 +++++
src/.depend | 816 +++++++++++++++++++++++++++++++++++++++
41 files changed, 5985 insertions(+)
As you know - you should avoid to have files external from the debian
subdir in your *.diff.gz, since that was the reason to introduce dpatch
as you did which was quite good work. :) I guess all this stuff here can
be fixed by fixing the "clean" target in your debian/rules.
In debian/changelog you mentioned the "modificationm of the default
config file", but there's neither a diff in the diff.gz nor a config
file in the debian subdir, I recommend you to add an own one under the
debian subdir which you install then by hand somewhere as conffile.
Also you should document in debian/changelog the 2 added patches and
very shortly what they do.
Yeah, that's really fine and the small issues were fixed. This file is
in an uploadable state. :)
But I have a question: Why do you not recommend/suggest any IRC servers?
(This was a only a question to you and not a way to force to do it).
You did a good job here too.
Please use the CFLAGS and LDFLAGS declaration at the beginning of the
line where you call ./configure.
Please don't use "rename", better use simple stuff as mv or cp.
Please fill out the headers of the two dpatch files... Correct author,
E-Mail address and description.
Ok, if you fix all that stuff I think we're ready to upload your
package. Thank you for your good work.
.''`. Mario Iseli <email@example.com>
: :' : Debian GNU/Linux developer
`- Debian - when you have better things to do than fixing a system
- RFS: atheme
- From: Bradley Smith <firstname.lastname@example.org>