Re: RFS: gnome-specimen
On Tue, Jul 24, 2007 at 08:22:02AM +0530, Kartik Mistry <kartik.mistry@gmail.com> wrote:
> On 7/24/07, Mike Hommey <mh@glandium.org> wrote:
>> On Mon, Jul 23, 2007 at 12:35:17PM +0530, Kartik Mistry
>> <kartik.mistry@gmail.com> wrote:
>> > Dear mentors,
>> >
>> > I am looking for a sponsor for my package "gnome-specimen".
>
> Hi Mike,
>
> First of all, thanks for looking at package!
>
>> Just a few notes:
>> - In the manpage, I would add an article ('a') between "gnome-specimen
>> is" and "simple tool".
>
> Done.
>
>> - In the manpage, still, most of the options (especially bonobo activation
>> and gnome library options) are pretty useless.
>
> Hmm. It is meant for advance user or developer. But, should I keep it
> or remove it. I think there is no harm to keep it in manpage.
Advanced user or developers don't need useless items in a manpage ;)
What use can the --enable-esound flag be in gnome-speciment, for
example ?
For bonobo options, they are common to all gnome applications using
bonobo, do you really think it's necessary to repeat these instructions ?
And I'm not sure the modules loading functionality is of any use...
>> - I think you should build depend on python-dev instead of
>> python-all-dev.
>
> python-all-dev will make sure that all supported python version are
> installed. correct me if I am wrong. python-dev is also ok in our
> case.
I got misleaded by overlooking at the code of the resulting package.
Looking again, I see it's only a hack to be able to run modified version
from the source tree. Maybe you should remove that. It's useless in the
installed version, and adds python 2.4 paths even when using python 2.5,
which could have bad side effects.
Anyways, python-gnome2 only comes for python 2.4...
>> - I don't really know cdbs, but i guess you can either put all your
>> build dependencies in build-depends or build-depends-indep.
>
> Build-Depends: cdbs, debhelper (>= 5), python-central (>= 0.5)
> Build-Depends-Indep: intltool, libgconf2-dev, python-dev (>= 2.4)
>
> Right? cdbs, debhelper and python-central are require for clean target.
Fair enough.
>> I'm not confortable with sponsoring a package using cdbs, but if nobody
>> steps in, I will, since I'm very interested in having this in the
>> archive.
>
> If you wish, I can convert it to debhelper, no problem :) Let me know,
> I will upload corrected package.
Let's first see if someone wants to take care of this.
Mike
Reply to: