[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gimmie



Hi Michael,

Sorry for the delay, I'm very busy these last weeks,
I changed the package and uploaded it.

http://mentors.debian.net/debian/pool/main/g/gimmie/gimmie_0.2.7-1.dsc

Michael Biebl wrote:
> Thierry Randrianiriana schrieb:
[...]
> 
> the package looks well done, I only have some smaller points:
> 1.) Package description
> gimmie seems to be a replacement/enhancement of the traditional (GNOME)
> panel and it can either be run in standalone mode or as applet in the
> GNOME panel. This information is somehow missing in the description.
> 2.) The second paragraph in the long descriptions does not show nicely
> in aptitude. The separate points are not correctly wrapped and thus it
> gets a bit unreadable.
I changed the description but feel free to change it to improve it :)

> 3.) python-support
> IIRC the recommended way to specify the supported python versions with
> python-support is debian/pyversions [1]. But as python-support also
> supports the XS-Python-Version field, you can also keep it as is.
added

> 4.) ./configure checks for a couple of python modules like gmenu etc,
> which are are not added to the the Depends list of gimmie. Could you
> elaborate on that? Should these python modules be added to the list of
> runtime dependencies?
fixed, I added these dependencies to Build-Depends

> 5.) debian/copyright
> gdm-logout-action.c is missing
fixed

> 6.) inlined copy of libsexy
> gimmie uses a inlined copy of libsexy. I would very much prefer if
> gimmie could be made to use the system libsexy. See [2] for more
> details. Maybe you can also forward this information to upstream.
> 
done

> If you can address the above issues, I'll gladly sponsor your package.

Thank you very much for your help :)

Best regards,

--
Thierry Randrianiriana


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: