Re: RFS: thwab-lib

["Paul Wise" <pabs@debian.org>]

On 7/7/07, Ahmed El-Mahmoudy <aelmahmoudy@users.sourceforge.net> wrote:

> http://mentors.debian.net/debian/pool/main/t/thwab-lib/thwab-lib_1.1.2-1.diff.gz

No time for sponsoring, some comments:

New upstream release for a package not yet in debian?

Please file an ITP and close it in the changelog

What happens when there are left files on the disk in group thwab?

Lots of not-so-useful comment lines in the postinst/prerm/rules.

Send the manual page upstream if you haven't already.

debian/doc-base needs re-writing, I'm sure thwab has nothing to do
with managing online manuals

Copyright (C) 2007 Muayyad... is not a part of the licence, please put
it in a separate Copyright section in debian/copyright

The needs bit of debian/menu needs fixing.

Might want to add an icon based on the upstream .png file (use
imagemagick/convert at build time) to the debian/menu file.

You modified the .desktop file, please validate it with
desktop-file-validate from desktop-file-utils and indicate the result
in the patch description.

Might want to change the patch to split the install process into
install and install-package targets (then the package would use make
install-package instead of make install), so the patch is useful to
upstream.

Don't forget to send the patches upstream.

May want to evaluate and use quilt for the patches instead.

--
bye,
pabs

http://wiki.debian.org/PaulWise