[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: proda

* David Paleino <d.paleino@gmail.com> [2007-04-24 17:46]:
> I am looking for a sponsor for my package "proda".
> * Package name    : proda
>   Version         : 1.0-1
>   Upstream Author : Phuong T.M., Do C.B., Edgar R.C., Batzoglou S.
> * URL             : http://proda.stanford.edu
> * License         : public domain [1]
>   Section         : science
> It builds these binary packages:
> proda      - multiple alignment of protein sequences
A few comments:
- copyright lacks upstream email, would be good to see it 
- watch file seems broken:
  uscan warning: In debian/watch,
  no matching hrefs for watch line

  opts="uversionmangle=s/_/\./" \
  should be correct, shouldn't it?
- you included manpage.xml but you don't convert it while building?
- you have Uploader in control it has to be Uploaders
- you directly patched Makefile, why not using dpatch or quilt?
  (or just do the rm proda and instal from within rules, patching is
   not really needed here and you never call distclean)

Kind regards
Nico Golde - http://ngolde.de - nion@jabber.ccc.de - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.

Attachment: pgpkwOY3uelPu.pgp
Description: PGP signature

Reply to: