[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: swftools - a collection of SWF utilities



Hi Simo,

> The debian package files are in
> http://www.mediasitomo.com/debian-swftools/

Thanks for your work! I've reviewed the package.

* debian/copyright does not seem to list that most of the contents of
  the lib/ dir are licenced under the LGPL.

* debian/compat: Since you depend on debhelper >=5, you could increase
  the compatibility level to 5 aswell.

* debian/patches: your patch filenames have some very generic names,
  like "05-bugfix.dpatch", and the patches themselves do not have
  a description inside it. Might be useful to add a description of
  the patch, so it's clear to anyone else looking at the package what
  the intention is.

Otherwise, it looks ok, but at least the first point needs to be
addressed to make the package suitable for upload.


Thijs

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: