Re: RFS: speedometer -- measure and display the rate of data across a network connection
Jari Aalto wrote:
>> * configure: stanza in rules is unused, remove it. same with build:
>> (but since build: is a mandatory target, just leave an empty build:
>> in rules)
>>
>> * remove the useless commented stuff, e.g. in clean:
>>
>> * remove the not used dh_* calls for your package, e.g.
>> dh_installexamples and others.
>>
>
> I would rather keep those for maintenence purposes and I find they keep
> the packaged uniform with all the steps visible. After all, comments
> are comments, in all programming languages. Leaving the unused dh_*
> calls is permitted by New Debian New Maintainers' Guide[1].
this is what you have:
---snip---
configure: configure-stamp
configure-stamp:
dh_testdir
# Add here commands to configure the package.
touch configure-stamp
build: build-stamp
build-stamp: configure-stamp
dh_testdir
# Add here commands to compile the package.
# $(MAKE)
#docbook-to-man debian/speedometer.sgml > speedometer.1
touch $@
clean:
dh_testdir
dh_testroot
rm -f build-stamp configure-stamp
# Add here commands to clean up after the build process.
# -$(MAKE) clean
dh_clean
install: build
dh_testdir
dh_testroot
dh_clean -k
dh_installdirs
# Add here commands to install the package into debian/speedometer.
# $(MAKE) DESTDIR=$(PKGDIR)
install -D -m 755 $(BIN) $(PKGDIR)/usr/bin/$(PACKAGE)
# Build architecture-dependent files here.
binary-arch: build install
# We have nothing to do by default.
# Build architecture-independent files here.
binary-indep: build install
dh_testdir
dh_testroot
dh_installchangelogs
dh_installdocs
dh_installexamples
# dh_install
# dh_installmenu
# dh_installdebconf
# dh_installlogrotate
# dh_installemacsen
# dh_installpam
# dh_installmime
# dh_python
# dh_installinit
# dh_installcron
# dh_installinfo
dh_installman debian/*.1
dh_link
dh_strip
dh_compress
dh_fixperms
# dh_perl
# dh_makeshlibs
dh_installdeb
dh_shlibdeps
dh_gencontrol
dh_md5sums
dh_builddeb
binary: binary-indep binary-arch
---snap----
and this is how i recommend to do it:
---snip---
build:
clean:
dh_testdir
dh_testroot
dh_clean
install: build
dh_testdir
dh_testroot
dh_clean -k
dh_installdirs
# Add here commands to install the package into debian/speedometer.
install -D -m 755 $(BIN) $(PKGDIR)/usr/bin/$(PACKAGE)
# Build architecture-dependent files here.
binary-arch: build install
# We have nothing to do by default.
# Build architecture-independent files here.
binary-indep: build install
dh_testdir
dh_testroot
dh_installchangelogs
dh_installdocs
dh_installman debian/*.1
dh_link
dh_compress
dh_fixperms
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
binary: binary-indep binary-arch
---snap---
if you insist on keeping the useless stuff, i consider the package as to
ugly according to my mesures of beauty, and hence i'm not sponsoring it.
> fspanes has been fixed. Thank you for the comments. The new package(s)
> are ready at:
you didn't fix the things here:
http://lists.debian.org/debian-mentors/2007/01/msg00220.html
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: daniel.baumann@panthera-systems.net
Internet: http://people.panthera-systems.net/~daniel-baumann/
Reply to: