Re: RFS: libitpp
On 02/01/07, Daniel Baumann wrote:
Kumar Appaiah wrote:
> http://mentors.debian.net/debian/pool/main/l/libitpp/libitpp_3.10.7-1.dsc
Please find the new files here; I am having problems with Debian Mentors:
http://www.ee.iitm.ac.in/~ee03b091/Upload/libitpp_3.10.7-1.dsc
http://www.ee.iitm.ac.in/~ee03b091/Upload/libitpp_3.10.7.orig.tar.gz
http://www.ee.iitm.ac.in/~ee03b091/Upload/libitpp_3.10.7-1.diff.gz
http://www.ee.iitm.ac.in/~ee03b091/Upload/libitpp_3.10.7-1_i386.changes
* remove the useless empty line at the end of changelog.
Done.
* i just saw you uploaded revison -2. revert the revision to -1 again,
the bump is useless when the previous revision wasn't uploaded to
debian.
Done.
* why priority extra? i think, optional is ok here.
Made it optional.
* the dev package should not contain the soname, rename it to
libitpp-dev.
Done.
* since the documentation is not a huge "stand alone" manual,
i don't think a dedicated -doc package is justified. just
include the stuff in the -dev package.
Done.
* debian/docs is a helper file not prefixed with the package name.
for consistency reasons, i recommend to rename it do the package
you want to assign it, otherwise it is automatically assigned to
the first package listed in control, which makes it less
error-prone to read the sources.
Done.
same with debian/manpages.
Done.
* at the end of the manpage, you wrote:
---snip---
This manual page was written by Kumar Appaiah <aku-
mar@ee.iitm.ac.in>, for the Debian project (but may be used by oth-
ers).
---snapp---
never do the hyphenation yourself, groff is just takeing care about
this dynamically itself.
Done.
* this here:
---snip---
# shared library versions, option 1
version=2.0.5
major=2
---snap---
in your rules file is not needed, you can remove it.
Done.
* another tipp about rules: do not use more than multiple empty line
as a seperator, one is just enough.
Fixed that as well.
the rest is good, if you fix above things, i'll sponsor the package.
Please check that things are fine. Otherwise, I'll get back to you
with necessary changes.
Thanks.
Kumar
--
Kumar Appaiah,
462, Jamuna Hostel,
Indian Institute of Technology Madras,
Chennai - 600036
Reply to: