Re: RFS: uebimiau

[Shachar Shemesh <shachar@debian.org>]

Muammar Wadih El Khatib Rodriguez wrote:
> I have made another version for you to check [0]. I'd be glad if you
> check it.
>
> Thanks,
>
> [0] http://mentors.debian.net/debian/pool/main/u/uebimiau/

Hi Muammar

A few comments:

    * First, the tar.gz you use has changes from the zip that you can
      download from the site, including a file that is only generated
      during the Debian build process. The two should be identical. The
      best thing for you is to, first thing, grab the zip file, extract
      it, and create the tar.gz. Only then do any Debian related work on it.
    * In debian/apache.conf, you have slightly inconsistent indenting
      policy (not crucial, but if we're fixing stuff, let's fix this as
      well).
    * Your default apache config should be to have
      http://whatever/uebimiau. Ideally, many users should not have to
      touch anything in order to start using the package once installed.
      Ideally, make sure that your current "apache.conf" is simply
      installed to "/etc/apache2/conf.d/uebimiau.conf"
    * In "README.Debian" - Uebimiau's Configuration. This should not be
      something that the user need to do after install. This is
      something that the package should do during install. Create the
      relevant directories using dh_installdirs, set the variables in
      /etc, etc.
    * /etc/uebimiau seems to contain php files that answer the title
      "plugins" much more than they do the title "configuration". These
      should not be under /etc. I'm not talking about config.php and the
      other config*.php, but on class.phpmailer.php and friends. This
      may require some patching to the code (for example, change
      "./inc/config.php" to "./conf/config.php" in all relevant places),
      but that's what the diffs that come with Debian sources are for.
      In any case, do not be tempted to patch your "upstream".

This is what I found. Let me know how things go.

Shachar