[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFC: AKFQuiz (was: new here)



On Fri, 24 Nov 2006 15:05:20 +0100 (MET)
"Andreas K. Foerster" <list@AKFoerster.de> wrote:

> Am Freitag, dem 24. Nov 2006 schrieb Thibaut Paumard:
> 
> > On Thu, 23 Nov 2006 20:45:32 +0100 (MET)
> > "Andreas K. Foerster" <list@AKFoerster.de> wrote:
> > > > > The program dh_make(?) has put the files config.guess and config.sub
> > > > > into my source-tree.[...]
> > > > 
> > > > [...] Just remove whatever you don't need.
> > > 
> > > I deleted the files, but dpkg-buildpackage created them again.
> > 
> > Have a look at the rules file then. [...]
> 
> Well, I give up. They don't appear in the .deb file anyway, just in the
> .diff file.

Looks to me that those lines (in debian/rules, clean target) you want to delete:
+ifneq "$(wildcard /usr/share/misc/config.sub)" ""
+       cp -f /usr/share/misc/config.sub config.sub
+endif
+ifneq "$(wildcard /usr/share/misc/config.guess)" ""
+       cp -f /usr/share/misc/config.guess config.guess
+endif

> Could anyone have a look at my package? 
> I have put all the files online now:
> http://akfoerster.de/download/debian/

You should give the dget line:
 dget http://akfoerster.de/download/debian/akfquiz_4.4.0-2.dsc

> It is lintian-clean now, but I still think that there are still things
> to fix...

A very quick look: 
 1) you don't need to bump the Debian version for you internal stuff.
You can stay with "-1" as long as you didn't publish your work to a
wide audience. This will keep the changelog clean. If all you want is
to provide upgrade possibility, I would suggest using something like
-1~pre0, -1~pre1 etc., dropping the ~ part for the eventual upload (and
keeping a single entry in the changelog, for that matter).

 2) it seems to me that some of your changes, present in the diff,
ought to belong in your upstream, like that bit for instance:
--- akfquiz-4.4.0.orig/doc/deutsch/mkquiz.1
+++ akfquiz-4.4.0/doc/deutsch/mkquiz.1
@@ -1,11 +1,13 @@
 .\" Process this file with
 .\" groff -man -Tlatin1 mkquiz.1
 .\"
-.TH "mkquiz" 1 "4.2.0" AKFQuiz
+.TH "mkquiz" 1 "4.4.0" AKFQuiz

I may have a deeper look over the week-end (no promise, though... And
IANADD anyway...)

Regards, Thibaut.

-- 
Dr Thibaut Paumard       | LESIA - B. Lyot (n°6)
Tel: +33 1 45 07 75 45   | Observatoire de Paris - Section de Meudon
Fax: +33 1 45 07 79 17   | 5, Place Jules Janssen
thibaut.paumard@obspm.fr | 92195 MEUDON CEDEX (France)



Reply to: