[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: kodos - A visual regular expression editor - (updated package)



* Kevin Coyner <kevin@rustybear.com> [2006-10-25 23:05:29 -0400]:

> 
> Dear friends,
> 
> I am looking for a sponsor for the new version 2.4.9-4 of a package I am
> adopting called "kodos".  I use this program and since it was recently
> orphaned, I decided to adopt it.
> 
> It builds this binary packages:
> 
>     kodos - A visual regular expression editor
> 
> The package is lintian/linda clean and builds just fine in pbuilder sid.
> I've tested the update and it works as you would expect.

Kevin,

I built kodos in a sid pbuilder and installed the resulting package. Running
"kodos" didn't work. Here is the traceback:

Traceback (most recent call last):
  File "/usr/bin/kodos", line 30, in ?
    from modules.kodosBA import *
ImportError: No module named modules.kodosBA

It looks to me that the problem is in the following change:

--- ../2.4.9-3/kodos-2.4.9/kodos.py	2006-10-26 10:00:45.000000000 -0600
+++ kodos-2.4.9/kodos.py	2005-12-16 15:47:29.000000000 -0700
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python
 #  kodos.py: -*- Python -*-  DESCRIPTIVE TEXT.
 
 import sys
@@ -23,7 +23,7 @@
 import os.path
 from distutils.sysconfig import get_python_lib
 
-sys.path.insert(0, "/usr/share/kodos")
+sys.path.insert(0, os.path.join(get_python_lib(), "kodos")) 
 
 ###################################################################

I've changed it to:

--- kodos-2.4.9/kodos.py	2005-12-16 15:47:29.000000000 -0700
+++ kodos.py	2006-10-26 10:34:09.000000000 -0600
@@ -23,7 +23,7 @@
 import os.path
 from distutils.sysconfig import get_python_lib
 
-sys.path.insert(0, os.path.join(get_python_lib(), "kodos")) 
+sys.path.insert(0, os.path.join(get_python_lib(), "/usr/share/kodos"))
 
 ###################################################################

to fix the problem. In the future consider using a patch management system
such as dpatch. It is quite easy to use and is meant exactly for this kind of
upstream source patching.

> The upload would close this ITA bug: #394936
> 
> Changelog from this update:
> 
>   kodos (2.4.9-4)
>   * New maintainer. Closes: #394936.
>   * Updated Standards-Version to 3.7.2.2.  No changes.
>   * Changed Build-Depends from python-dev to python-all-dev.
>   * Updated debian/compat to 5.
>   * Updated debian/watch to version 3.
>   * Updated debian/copyright with correct FSF address and to proper Debian policy.
>   * Wrote and added a basic man page.
>   * Converted menu icon from .png to .xpm format.
>   * Added homepage to debian/control.

You should document all changes you make such as that modification to the
sys.path.insert line in kodos.py.

> Many thanks in advance!
> 
> Kevin
> 
> -- 
> Kevin Coyner  GnuPG key: 1024D/8CE11941

Uploaded.

Regards,

Alex.

Attachment: signature.asc
Description: Digital signature


Reply to: