[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: drapes (updated)

On (23/09/06 15:40), Francesco Namuri wrote:
> > * debian/copyright
> >  - you missed to insert copyright notes for many files: (apart from
> > Makefiles and other generated configure scripts)
> >    + ./po/{de,es,fr,it,ko,nl,pl,pt_BR,sv}.po are copyrighted by Canonical
> >    + ./drapes/panelapplet/PanelAppletFactory.cs by Novell
> >    + ./drapes/Traylib.cs is copyrighted by three different entities,
> > and is under MIT license.
> >  I know it's boring execute " find . -type f -exec less '{}' \; " but
> > you _have to_ do it, and report in debian/copyright every copyright
> > notice for files in your package.
> I've added the copyright information for these files, but I have one
> doubt: do I have to add copyright informations also to Makefiles and
> other generated configure scripts?

No, this is usually left out unless there is something special about it.

> > * NEWS
> >  - this seems to be the upstream changelog, and it has to be treated
> > so: called changelog, and installed (after gzip -9 ) into
> > /usr/share/doc/drapes/changelog.gz . Give a look at
> > dh_installchangelogs
> I think it's already done, because in /usr/share/doc/drapes/ there is
> the file NEWS.gz which is the gziped copy of the NEWS file of the tarball

Sandro was suggesting you install it as changelog.gz rather than
NEWS.gz, but I'm not sure that is necessary.

> >  - dh_install debian/pixmap/drapes.xpm /usr/share/pixmaps/
> >    it's better if you install it locally, $(CURDIR)/debian/drapes/usr/....
> ok, fixed the first two issues, but I thought dh_install makes already the
> copy locally... I'm wrong?

If your method works then that's ok.

> > * config.{guess,sub}
> >  - take care of those files: they can create many problems. you can
> > look at /usr/share/doc/autotools-dev/README.Debian.gz
> I have applied config.dpatch because debian/rules, based on the template
> of dh_make, makes a copy of these files from /usr/share/misc, alterating 
> the original tarball, with the side effect of including the updated 
> config.guess and config.sub in the diff.gz.
> In this manner, I hope to have followed correctly the
> /usr/share/doc/autotools-dev/README.Debian.gz guidelines...

Your solution is interesting, but it is not the normal way of doing it.

Also if you are not using the lines in debian/rules, then delete them,
don't leave them commented out.

> > * debian/watch
> >  - as of now it's missing: please evaluate to add it: it will easy
> > noticing of new upstream releases. Upstream tarball patch is rather
> > funny: maybe you can contact him and ask to change in something more
> > easy to manage.
> added, hoping it's ok...
> > * debian/patches
> >  - please include description for patch 01_data_Makefile.in.dpatch
> >  - 02_config.dpatch is provided by Ralf Treinen <treinen@debian.org>:
> > should he be mentioned in debian/copyright? Some DDs can comment on
> > this?
> the first issue is fixed, but I don't know  what to do with the second one...

If copyright has been asserted on the file then it must be mentioned in
debian/rules, along with its distribution license. If there isn't one
you should find out what it is and add it, or drop the file.

> two questions:
> during the build of the package, I got these warnings:
> 1) warning: no utmp entry available and LOGNAME not defined; using uid
> of process (1234)

This is normal, annoying, but normal. It is a documented problem in

> 2) WARNING: failed to install schema
> `/schemas/apps/drapes/enable_timed_shuffle' locale `fr': Unable to store
> a value at key '/schemas/apps/drapes/enable_timed_shuffle', as the
> configuration server has no writable databases. There are some common
> --CUT--

Depends what you mean by normal. It seemd to be something in the build
of your package, and as such probably wont have been seen in any other
packages. You should find out what it means and if it is a problem.


  James Westby   --    GPG Key ID: B577FE13    --     http://jameswestby.net/
  seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256

Reply to: