[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: oo2-voikko



On (21/09/06 18:12), Timo Jyrinki wrote:
> Lovely mentors,
> 
> * Package name    : oo2-voikko

Hi, last one,

  * ITP and Homepage: again.
  * debian/copyright again.
  * The copyright status of the upstream work seems unclear, I think you
    should seek to clarify it.
  * Remove the cruft from debian/watch.
  * The system of substrvars you have used is a little strange, I don't
    know what to make of it. You might also want to use your own
    namespace for the variables in case they are used by anything else
    in the future.
  * The upstream build uses CC_FLAGS rather that CFLAGS, the consequence
    of which is that the package is built without -g.
  * The binary package name differs from the source package name again.

James

-- 
  James Westby   --    GPG Key ID: B577FE13    --     http://jameswestby.net/
  seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256



Reply to: