Re: RFS: (malaga), suomi-malaga, libvoikko, tmispell-voikko, oo2-voikko
On (21/09/06 18:12), Timo Jyrinki wrote:
> Lovely mentors,
>
> * Package name : libvoikko
Hi again,
I'm back to finish off the rest of the packages.
* I saw you filed ITPs for all the packages, make sure you include the
bug number in the changelog. (Apologies if you have done so already)
* Please switch to ${binary:Version} in debian/control[0].
* The Homepage: field is indented two spaces by convention[1].
* Your debian/copyright needs more work. There is an extra copyright
holder, and the text of a license header needs including[2]. You
should also add a statement about copyright and license of your
packaging.
* You have
dh_shlibdeps -L libvoikko1 -l debian/libvoikko1/usr/lib
in your debian/rules. What is this for? Does it not generate the
correct information for the packages without it? It may be fixed by
reversing the order or the packages in debian/control.
* Building in pbuilder fails with
/bin/sed: can't read /usr/lib/libglib-2.0.la: No such file or
directory
This is a missing build-dep on libglib2.0-dev.
* There is a lintian message about the manpage, you may want to fix
it
I: libvoikko-dev: hyphen-used-as-minus-sign
usr/share/man/man1/voikkospell.1.gz:43
James
[0] http://lists.debian.org/debian-mentors/2006/09/msg00228.html
[1] http://www.debian.org/doc/manuals/developers-reference/ch-best-pkging-practices.en.html#s-bpp-upstream-info
[2] http://lists.debian.org/debian-devel-announce/2006/03/msg00023.html
--
James Westby -- GPG Key ID: B577FE13 -- http://jameswestby.net/
seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256
Reply to: