Re: RFS: vim-latexsuite
Hello Thijs,
> It looks fine. I can't upload the package for you, but I do have some
> comments which may help to further improve the package:
>
> - Description: I don't like the short and long description. I realise
> you didn't make it up but it's your responsibility now :)
[..]
> The short description doesn't really tell one what exactly this
> package brings to Vim. The long description already does a bit better,
> but I'd put the second paragraph first, because that's the one that
> actually tells us what this does. The first paragraph is quite
> redundant and I suggest you just drop it, or at least move it down.
>
> Maybe change the short one to "View, edit and compile LaTeX documents
> entirely from within Vim".
Yes, you're perfectly right. I'll think of something pretty by tomorrow.
> - You've made some miscellaneous changes but you didn't mention them in
> the changelog:
> * New upstream release
> * Adoption of package (Closes: #307166)
> For example: you've updated the standards-version, you've added a
> dependency and made changes to debian/rules. Please make sure you
> document all the packaging changes you make in your changelog.
Ok, will do. I thought that such small changes shouldn't be in the
changelog but, well, I'm new though already having read some of
extensive Debian documentation. ;-)
> - Standards-Version: you've changed this to 3.6.2.2, I'd suggest to
> state just "3.6.2". The last part of the version number indicates
> only textual/formatting revisions to the policy so it's not
> significant for the package (i.e.: you never need to make changes
> to your package between 3.6.2.2 and 3.6.2.3).
Thanks for clarifying it, done.
> - debian/rules: for clarity, please remove the commented-out dh_*
> commands.
Done.
> - debhelper: you could consider moving to debhelper compatibility
> level 5 (newest and recommended) but this is not necessary.
Done.
> - debian/copyright: doesn't list the years of the copyright, please see
> http://lists.debian.org/debian-devel-announce/2006/03/msg00023.html
I've added the years and some other things suggested by this mail.
Thanks for bringing it to my attention.
> Good luck with the adoption, and if you look at these points I'm pretty
> sure that someone will sponsor you.
Thank you very much for your corrections and suggestions. I've uploaded
a corrected version of the package.
> bye,
> Thijs
Cheers,
Franz
--
Franz Pletz \ The Internet treats censorship as
www: http://franz-pletz.org/ \ damage and routes around it.
email: fpletz@franz-pletz.org \ -- John Gilmore
Reply to: