On Mon, 2006-04-10 at 03:34 +0200, Miriam Ruiz wrote:
> swfmill is an xml2swf and swf2xml processor with import functionalities
Some comments:
* debian/watch: only needs 2 lines - version and url. may want to
allow uscan to auto-run uupdate - add " debian uupdate" to the
end of the url line
* debian/copyright: you miss out the copyright years, please see
http://lists.debian.org/debian-devel-announce/2006/03/msg00023.html also looks like Herman Narkaytis did no assert copyright over any part of swfmill. He may be an author but that doesn't make him a copyright holder.
* debian/copyright: you miss out copyright and licence info from
src/swft/readpng.* Even worse, those files contain an obnoxious
BSD advertising clause (clause 3).
* debian/control: shouldn't swfmill-dev be named libswfmill-dev?
* debian/rules: you commented out dh_installmenu, do you intend to
add a menu file?
* debian/swfmill.1: you might want to mention mtasc(1) in the SEE
ALSO section (since it is now in debian).
* the package FTBFS in pbuilder. you need to add pkg-config to the
build-depends.
* you need to check the package with lintian/linda. I get
warnings:
W: libswfmill0: package-name-doesnt-match-sonames libswfmillxslt0 libswft0
W: swfmill; A binary links against a library it does not use symbols from
W: libswfmill0; A binary links against a library it does not use symbols from
--
bye,
pabs
http://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part