[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS vamps (ITP #320067)

This one time, at band camp, Claudio Moratti said:
> On Saturday 24 December 2005 13:33, Stephen Gran wrote:
> > debian/rules:
> > You conditionally copy in config.{sub,guess} but unconditionally rm
> > them.  This is not idempotent and will lead to failures to build a
> > second time.
> uhm...
> I could remove the condition, because at first time the debian/rules remove 
> the config.{sub,guess} and, after a dist-clean, copy them 
> from /usr/share/misc/ dir...
> I don't see how it could not work or it creates problems...

I was mistaken - you build-depend on autotools-dev, so it will work
correctly in this case.  But I was also just trying to nudge you towards
what I see as good practice; if something is error prone enough to
warrant a condition in one place, it is probably enough to warrant a
condition throughout.  If not, no problem.

> > debian/NEWS:
> > cron (3.0pl1-74) unstable; urgency=low ...
> > ?? This looks like a cut and paste error.
> removed...


> > debian/libk9copy0.files:
> > usr/lib/libk9copy.la should go in the -dev package
> uhm...
> there is a 'little' problem:
> if I put the .la file in -dev package, k9copy does not run correctly...

steve@gashuffer:~/k9copy-1.0.2$ head debian/libk9copy0/usr/lib/libk9copy.la
# libk9copy.la - a libtool library file
# Generated by ltmain.sh - GNU libtool 1.5.20 Debian 1.5.20-2 (1.1220.2.287 2005/08/31 18:54:15)
# Please DO NOT delete this file!
# It is necessary for linking the library.

If k9copy really needs a libtool helper file to run, something odd is
going on.

> > debian/dirs:
> > You install /usr/lib/k9copy/ in k9copy, but the libraries are installed
> > into /usr/lib/.  Probably the best thing is to just drop that directory
> [cut]
> > libk9copy.install to install the files in the subdirectory.
> I removed this directory...


> > debian/menu:
> > I'm not sure what to say here.  There seems to be very little coherence
> > in Debian proper about where things are dumped in the menu hierarchy,
> [cut]
> > I am not saying you have to change anything, just mentioning it.
> But You're right...
> I selected 'graphics' section because k9copy works with 'graphics things', but 
> it is like a 'bigger tool', because it create an ISO, but it could also write 
> it to a DVD...
> BTW Debian menu is a little beat 

Yes, it's slowly getting better, but you are right.  It was designed
before the freedesktop standards for menus, and was not really
maintained for a while.  It does have the advantage of working for every
single window manager Debian ships, which is something that I don't
think any of the other systems can claim just yet, though, so it's
better than nothing.  But it is still a bit of a mess.  Hopefully the
discussion currently going on around it will improve things.

Take care,
|   ,''`.                                            Stephen Gran |
|  : :' :                                        sgran@debian.org |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |

Attachment: signature.asc
Description: Digital signature

Reply to: