[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS - kommando - ITP #336607



On Tuesday 01 November 2005 14:42, Sune Vuorela wrote:
> I have built kommando, a kde wheel menu.
>
> It gives quicker access to some programs - and it is a nice piece of
> showoff-eyecandy ;)
>
> http://mirror.pusling.com/kommando-rfs/
>
> I have had people using the package for some time now - but I think it
> is a so cool program that it should enter debian.
>
> and of course - those picky programs, linda and lintian, do not seem to
> have any errors/warnings

I would like to to take a look at it. Notes:

- the debian/copyright lacks the years of copyright
- insane number of Build-Depends - are they all necessary?
- still it doesn't build in a pbuilder so the dependencies are
  probably wrong [1]
- the debian/control refers to "Neverwinter Nights". Although I know
  what you mean that may not be clear to many. And it's probably a
  trademark. Suggestion:
  "A wheel-menu to quickly pick menu items with the mouse"
  The long description doesn't fully taste right to me but I don't have
  any creative suggestion here.
- You have created a nice man page. Did you send it upstream so it can
  be included in the orig.tar.gz at the next upstream release?
- debian/rules contains lines that can be removed (all the dh_*
  commands that are commented out). Also you probably don't need to
  call dh_installexamples or dh_link.

 Christoph


[1]
checking if Qt needs -ljpeg... no
checking for rpath... no
checking for KDE... configure: error:
in the prefix, you've chosen, are no KDE headers installed. This will fail.
So, check this please and use another prefix!
make: *** [config.status] Error 1
pbuilder: Failed autobuilding of package

-- 
    |\      _,,,---,,_        Famous last words of a sysadmin:
    /,`.-'`'    -.  ;-;;,_    "We'll do the backup tomorrow."
  <|,4-  ) )-,_..;\ (  `'-'
    '---''(_/--'  `-'\_)



Reply to: