Re: RFS: istanbul - Desktop session recorder (ITP: #316503)
On Tue, Sep 27, 2005 at 11:44:34AM +0200, Luca Bruno wrote:
> Christoph Haas <haas@debian.org> scrisse:
> > Very good. Just some thoughts:
>
> > - The revision number 0.1.1-0.1 looks like an NMU revision.
> > You probably don't mean that.
> > - please close the #316503 in your debian/changelog
>
> As I've already written in my previuos message, I used -0.1 because
> that is a not (yet) official package. Your fixes (and others as well)
> will be in -0.2 soon, for another revision here.
> -1 will be the revision for first sid upload.
> I'm going to close my ITP in -1.
> Please read also [1]...
Yes, I read that. Okay. I assumed that it's an NMU but it's right that
0.1 cannot be an NMU revision since -0 is not a valid revision either.
Although I personally prefer the "pre" syntax. If you want to keep that
I recommend you override the lintian warning though.
> > - "Not yet official Debian package." is nothing that has
> > really changed, is it? :)
>
> It is the original status of this package, like "Initial release".
> I'm going to put something like:
> "First official upload in debian (Closes: #316503)"
> in -1 revision...
> Is fine in this way?
That would be perfect. Closing the ITP bug with the first upload is
common practice.
> > - Great that you provide a menu file. Please consider using a
> > .desktop file too/instead.
> > (http://freedesktop.org/Standards/desktop-entry-spec)
>
> I think it is already provided within my package...
> Isn't "/usr/share/applications/istanbul.desktop" what are you looking
> for?
Uh, err, it was late... and dark... and I had too much coffee...
Point taken. ;)
> > - The README.Debian doesn't look very helpful for the end-user.
>
> Maint. Guide says: "Any extra details or discrepancies between the
> original package and your debianized version should be documented here."
> Isn't this the case (an extra manpage taken from another distro)?
> Should I really remove it?
Matter of taste. I would personally not include it. IMHO users should
first read the README.Debian to find out how the package works
specifically on Debian. Although it may be technically correct to tell
where you got the man page from it doesn't add much value to the
end-user. But that's up to you.
Another issue: the man page looks strange with an "empty" SYNOPSIS.
A first-time user would probably not have an idea how to use
"istanbul". (And actually I don't have an idea currently either. I can
start/stop a recording in the taskbar. And then? Where is the file?
How do I quit the program?)
Regards
Christoph
--
~
~
~
".signature" [Modified] 3 lines --100%-- 3,41 All
Reply to: