Re: RFS: wcalc

[Daniele Sempione <scrows@gmail.com>]

On Mon, Sep 05, 2005 at 12:06:37AM +0200, Kilian Krause wrote:
> Let's see:
> 
> $ diffstat *.diff.gz
>  config.guess                    | 1466 +++++++++++++++++++++++++++++++++++++
>  config.sub                      | 1579 ++++++++++++++++++++++++++++++++++++++++
>  configure                       |    6
>  debian/changelog                |    7
>  debian/compat                   |    1
>  debian/control                  |   21
>  debian/copyright                |   17
>  debian/docs                     |    4
>  debian/info                     |    1
>  debian/rules                    |  107 ++
>  debian/source.lintian-overrides |    1
>  debian/watch                    |   23
>  12 files changed, 3230 insertions(+), 3 deletions(-)
> 
> You altered the default prefix in configure, as well as using the
> --prefix=/usr as parameter to configure. No need to patch this.
ok

> Moreover the config.guess and config.sub are derived from autotools-dev.
> I guess you have taken the examples from README.Debian there; however i
> prefer to be running debuild without complaining about altered
> *.orig.tar.gz. That means your autotools and clean target should install
> and cleanup nicely. There's also some nice hints for cross-compilation
> which come in pretty handy (the confflags thingy). You might want to add
> these too.
uhm, right now I don't know what to do here

> Removing CVS dirs isn't really bad, but you might want to convince your
> upstream to release proper tarballs with "make dist".
Yes, I'll ask for it for the next releases

> Anyway, there's
> resulting diff in your orig.tar.gz compared to the 2.0 release on the
> website in your watch:
> $ LC_ALL=C diff -qr Wcalc-2.0 wcalc-2.0
> Only in Wcalc-2.0: .DS_Store
> Only in Wcalc-2.0: ._.DS_Store
> Only in Wcalc-2.0: .cvsignore
> Only in Wcalc-2.0: CVS
> Only in Wcalc-2.0/English.lproj: .DS_Store
> Only in Wcalc-2.0/English.lproj: ._.DS_Store
> Only in Wcalc-2.0/English.lproj: .cvsignore
> Only in Wcalc-2.0/English.lproj: CVS
> Only in Wcalc-2.0/English.lproj/MainMenu.nib: CVS
> Only in Wcalc-2.0/Wcalc.xcodeproj: CVS
> Only in wcalc-2.0: config.guess
> Only in wcalc-2.0: config.sub
> Files Wcalc-2.0/configure and wcalc-2.0/configure differ
> Only in wcalc-2.0: debian
> Only in wcalc-2.0: parser.c
> Only in wcalc-2.0: parser.h
> Only in wcalc-2.0: scanner.c
> $
> 
> What's the 3 files you've added? Missing in the clean target?
Yes, they are, should I do something with them?

> Are you sure Readme.rtf is a good choice for a readme file format?
> Somewhat it comes quite illegible in my vim. ;)
eheh.. I thought I can't edit such things.. anyway, now I converted it to
text and put it in README, I also removed it's `Installation section' ..

> Finally the lintian-overrides, I'm not sure this should be patched out.
> Rather propose a fix to your upstream. In the meantime you might want to
> use a dpatch if you feel like removing this warning.
ok

> > I get one warning from the man page because there is a very long line, but
> > some people said me it doesn't matter..
> 
> Should be alright, I guess. ;)
ok :)

> Apart from the comments above this should be ok to be sponsored.
=)

The update version can be found here: http://ilcrow.altervista.org/wcalc-2.0.stuff.tar

Thanks a lot!
Daniele

-- 
  GPG Fingerprint: 7B1F 0815 BB7D CF35 1018  EEAB 4B97 6382 F151 402D
                              -
  GPG Key [ID: 0xF151402D] available @ pgp.mit.edu
			-------------
APL hackers do it in the quad.