[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: Bustle - to do list manager with a difference



Hi

On Sat, 29 Jan 2005 11:38:53 +0100, Gaudenz Steinlin <gaudenz@debian.org> wrote:
> Hi Fred
> 
> Some more questions and suggestions concerning your package:
> 
> - As you are also the upstram author of Bustle, why do you fix your
>   makefile in the Debian diff and don't incorporate these changes in a
>   new upstream release?

Good point :) 
I've now added an ifdef in the Makefile, if destdir is not specified,
it will install to /usr/local/bin, if it is specified, it will install
to $(DESTDIR)/usr/bin

 > - Why do you build depend on libncurses5, libxcursor1, libxft2 and
>   libxrandr2? Shouldn't you either build depend on the respective -dev
>   packages or remove these dependcies altogether?
> 
> - Why are all your build dependecies versioned? Do you really know that
>   you need at least these versions or is this just a wild guess? If you
>   don't really need the versioned dependencies, I would remove them. And
>   you don't need to depend on gcc-3.3 if you just need a gcc (>= 3.3).
>   The build-essential package already depends on  gcc (>= 3:3.3), g++ (>=
>   3:3.3).

My dependencies were pretty much based on the script example from the
maintainers guide. I don't know of a reliable way to determine the
build dependencies otherwise. I've removed the lib dependencies, gcc
and the versions as you recommended. I've kept the version dependency
for debhelper as that was put there by a script, not sure if the
version is needed or not.

Thank you very much for your feedback :)

The new files are at:
http://www.strider.co.za/bustle-0.1.6.tar.gz
http://www.strider.co.za/bustle_0.1.6-1.diff.gz
http://www.strider.co.za/bustle_0.1.6-1.dsc
http://www.strider.co.za/bustle_0.1.6-1_i386.changes
http://www.strider.co.za/bustle_0.1.6-1_i386.deb

Kind regards
Fred

-- 
Fred Strauss
Obsidian Systems (Pty) Ltd.
http://www.obsidian.co.za
http://www.strider.co.za/gpg.pub



Reply to: