[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFC: test my debs for vegastrike



Hi!

I gave the .diff.gz a quick look, and I have a few things to note:

--- vegastrike-0.0.20020321.orig/debian/changelog
+++ vegastrike-0.0.20020321/debian/changelog
@@ -0,0 +1,12 @@
+vegastrike (0.0.20020321-1) unstable; urgency=low
+
+  * Initial Release.
+  * This is my first official .deb. Comments welcome!
+
+

<nitpick>Two empty lines, doesn't look nice</nitpick>

+ -- Mike Furr <mike.furr@umbc.edu>  Thu, 21 Mar 2002 21:24:39 -0500
+
+Local variables:
+mode: debian-changelog
+End:

You don't need these lines. They were there for
debian-change-log-mode, but since april 2001 (iirc), it doesn't need
them anymore, as it can autodetect debian changelogs.

--- vegastrike-0.0.20020321.orig/debian/control
+++ vegastrike-0.0.20020321/debian/control
@@ -0,0 +1,15 @@
+Source: vegastrike
+Section: games
+Priority: optional
+Maintainer: Mike Furr <mike.furr@umbc.edu>
+Build-Depends: debhelper (>> 3.0.0)

I believe you're missing some build-deps, like libsdl1.2-dev, and
probably python.

--- vegastrike-0.0.20020321.orig/debian/copyright
+++ vegastrike-0.0.20020321/debian/copyright
@@ -0,0 +1,15 @@
+This package was debianized by Mike Furr <mike.furr@umbc.edu> on
+Thu, 21 Mar 2002 21:24:39 -0500.
+
+It was downloaded from www.sourceforge.net/projects/vegastrike
+
+Upstream Author(s): Daniel Horn <hellcatv@hotmail.com>

Since there is only one upstream, you can drop the (s), it makes
things clearer, methinks.

--- vegastrike-0.0.20020321.orig/debian/docs
+++ vegastrike-0.0.20020321/debian/docs
@@ -0,0 +1,5 @@
+NEWS
+README
+README.MACOSX.rtf

I didn't look at the file, but doesn't that deal with MacOS? If yes, I
doubt you need to install it into the .deb.

--- vegastrike-0.0.20020321.orig/debian/rules
+++ vegastrike-0.0.20020321/debian/rules
[...]

+configure: configure-stamp
+configure-stamp:
+	dh_testdir
+	./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --bindir=/usr/games --with-data-dir=/usr/share/games/vegastrike --with-python-inc=/usr/include/python2.1/
+
+	touch configure-stamp
+

You can spare a stamp-file, by using config.status instead of
configure-stamp. Something like this:

config-status: configure
	dh_testdir
	./configure --yadayada
build-stamp: config.status


Also, there was a Makefile in one of the directories, I guess it
shouldn't be there. Furthermore, there are CVS/ stuff in both the
diff.gz and the .orig.tar.gz. If you're rolling the .orig.tar.gz
yourself, I'd drop the CVS/ things...

Apart from these, the package looks quite fine, good work!

Cheers,
-- 
Gergely Nagy \ mhp/|8]

Attachment: pgpO01kBbM_Ll.pgp
Description: PGP signature


Reply to: