routine-update builds twice, but does not clean after the first

[Steffen Möller <steffen_moeller@gmx.de>]

Hello,

That cleaning I had introduced between the builds somewhen was removed
and to avoid some ping-pong I thought we should talk about it. I presume
this is because of some system setting that runs cowbuilder when I run
it within the source tree. Can routine-update please somehow test for
that and give a warning to change the local configuration if we decide
not to clean?

Here what it looks like for me, i.e. a perfect build that has the
routine interrupted:


  dh_installdeb -O--buildsystem=pybuild
  dh_gencontrol -O--buildsystem=pybuild
dpkg-gencontrol: warning: unknown information field 'Breaks' in input
data in general section of control info file
dpkg-gencontrol: warning: unknown information field 'Provides' in input
data in general section of control info file
dpkg-gencontrol: warning: unknown information field 'Replaces' in input
data in general section of control info file
  dh_md5sums -O--buildsystem=pybuild
  dh_builddeb -O--buildsystem=pybuild
dpkg-deb: building package 'python3-pbcommand' in
'../python3-pbcommand_1.1.1+git20201023.cc0ed3d-1_all.deb'.
dpkg-genbuildinfo
dpkg-genchanges
 >../python-pbcommand_1.1.1+git20201023.cc0ed3d-1_amd64.changes
dpkg-genchanges: warning: unknown information field 'Breaks' in input
data in general section of control info file
dpkg-genchanges: warning: unknown information field 'Provides' in input
data in general section of control info file
dpkg-genchanges: warning: unknown information field 'Replaces' in input
data in general section of control info file
dpkg-genchanges: info: including full source code in upload
dpkg-source -i -I --after-build .
dpkg-source: warning: unknown information field 'Breaks' in input data
in general section of control info file
dpkg-source: warning: unknown information field 'Provides' in input data
in general section of control info file
dpkg-source: warning: unknown information field 'Replaces' in input data
in general section of control info file
dpkg-source: info: unapplying fix_version.patch
dpkg-source: info: unapplying python3.patch
dpkg-buildpackage: info: full upload (original source is included)
Now running lintian
python-pbcommand_1.1.1+git20201023.cc0ed3d-1_amd64.changes ...
Finished running lintian.
[master 640c4f3] routine-update: Ready to upload to unstable
1 file changed, 2 insertions(+), 2 deletions(-)
gbp:error:You have uncommitted changes in your source tree:
gbp:error:On branch master
Your branch is ahead of 'origin/master' by 7 commits.
 (use "git push" to publish your local commits)

Untracked files:
 (use "git add <file>..." to include in what will be committed)
       .pybuild/
       debian/.debhelper/
       debian/debhelper-build-stamp
       debian/files
       debian/python3-pbcommand.postinst.debhelper
       debian/python3-pbcommand.prerm.debhelper
       debian/python3-pbcommand.substvars
       debian/python3-pbcommand/

nothing added to commit but untracked files present (use "git add" to
track)


Thanks,

Steffen