Hi Andreas, Andreas Tille, on 2020-11-03 12:02:33 +0100: > On Tue, Nov 03, 2020 at 11:48:41AM +0100, Étienne Mollier wrote: > > > Exciting times, nim-docopt and nim-hts made it through new within the > > > same day, so we now have some first important fruit from these nim > > > dependencies: mosdepth! > > > > > > https://salsa.debian.org/med-team/mosdepth > > > > > > This is a major show stopper on the way to get bcbio complete. There are > > > some more nim modules missing for the hts-nim-tools that are also a dep > > > of bcbio - but .. .we are getting closer. Much closer :) > > > > To answer to the "peer review" aspect, running lintian against > > mosdepth_0.3.1-1.dsc got me at least: > > > > I: mosdepth source: unused-file-paragraph-in-dep5-copyright paragraph at line 9 > > I: mosdepth source: wildcard-matches-nothing-in-dep5-copyright intToStr.nim (line 9) > > Wow, how did you build the package? I haven't. I ran only against the source code, not binary packages. From the git repository, I basically run the following commands, and get some stems of source-only packages against which some linting can be done already: $ gbp export-orig gbp:info: Creating /home/emollier/debian/med-team/mosdepth_0.3.1.orig.tar.gz $ dpkg-source --build . dpkg-source: info: using source format '3.0 (quilt)' dpkg-source: info: building mosdepth using existing ./mosdepth_0.3.1.orig.tar.gz dpkg-source: info: building mosdepth in mosdepth_0.3.1-1.debian.tar.xz dpkg-source: info: building mosdepth in mosdepth_0.3.1-1.dsc (As a side note, I'm missing pristine-tar for version 0.3.1+ds.) > I just pushed fixed Build-Depends > and needed to set HOME to get a pbuilder build. I'm now running into > > ... > help2man mosdepth > debian/mosdepth.1 > help2man: can't get `--help' info from mosdepth > Try `--no-discard-stderr' if option outputs to stderr > make[1]: *** [debian/rules:14: override_dh_auto_build] Error 127 > > > So I solved two issues preventing me from building and are facing the > third one here. Did you do the same fixes and did not pushed to finally > get the package building? None, this was a very superficial check on my side. > > It looks like there is a typo in the debian/copyright file, or a > > file changed name. The entry: > > > > Files: intToStr.nim > > > > probably should actually be: > > > > Files: int2str.nim > > Just fix this and push. :-) I think Nilesh just beat me at it. ;) > > Other lintian issues would be sorted by routine-update, I think. > > > > On the other hand, having had a look at the following command: > > > > $ grep -Eir 'copyright|©|licen[sc]e' mosdepth/ > > > > I see no matter for issues. Binary files tests/empty-tids.bam > > and tests/nanopore.bam matches are confirmed false positives. > > :) > > Thanks for parallel checking You're welcome, Kind Regards, -- Étienne Mollier <etienne.mollier@mailoo.org> Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da Sent from /dev/pts/4, please excuse my verbosity.
Attachment:
signature.asc
Description: PGP signature