Re: Packaging libsis-jhdf5-java -- help needed
- To: Gilles Filippini <pini@debian.org>
- Cc: Andreas Tille <tille@debian.org>, Debian Med Project List <debian-med@lists.debian.org>, Debian Java List <debian-java@lists.debian.org>
- Subject: Re: Packaging libsis-jhdf5-java -- help needed
- From: Pierre Gruet <pgtdebian@free.fr>
- Date: Fri, 1 May 2020 07:48:14 +0200
- Message-id: <[🔎] ef330cb0-b31e-7b4a-6085-8b38c41c114a@free.fr>
- In-reply-to: <dffd73fe-fc2f-d27b-01c2-998524efd5ee@debian.org>
- References: <68857e65-b679-924f-08c7-e79ffe91d79e@free.fr> <20200429095922.GO1150@an3as.eu> <b2d920c4-4a62-7e60-6dce-fb1135ed6ed6@debian.org> <20200429153654.GR1150@an3as.eu> <167e766f-a18b-b7bc-dfd7-4fcea3fced43@debian.org> <662451e3-fe2b-20cc-bc1a-bc0869fe41c9@free.fr> <fe0b21be-3fc3-b87d-7044-d1dd59e64250@debian.org> <a5f279ef-44a2-3246-26aa-f33b915f48f2@debian.org> <71cac6e1-cac0-6977-73b7-60ce6d42f2c6@free.fr> <dffd73fe-fc2f-d27b-01c2-998524efd5ee@debian.org>
Hi Gilles,
Le 01/05/2020 à 01:12, Gilles Filippini a écrit :
> Pierre Gruet a écrit le 30/04/2020 à 23:45 :
>> Thanks for looking at the issue and proposing a fix. It is very helpful!
>> I will thus look at it and investigate further the failures that remain.
>
> This package looks weird. Where does the mix-up between libhdf5-java and
> libsis-jhdf5-java come from? There shouldn't have any dependency to
> libhdf5-java as I understand it. The tests failures come from this
> confusion.
>
> Using the attached patch, the package builds correctly and only 10
> failing test cases remain.
>
> BTW the override_dh_auto_clean target should be reintroduced.
>
> Best,
>
> _g.
>
Thank you for this additional feedback.
Concerning the mix-up, upstream was previously using a file from hdf5 to
build sis-jhdf5, I removed it some days ago.
I introduced other dependencies at that time and did not remove them...
thanks for your patch thus!
I was planning to consider a full refresh of debian/rules, including
dh_auto_clean.
Best regards,
Pierre
Reply to: