Hello Andreas and Andrius, A combined email again to save from constructing two different emails. > No, simply declare these in > debian/source/include-binaries Never knew that, thank you. Everything looks to be fine now and is building. > I'm about to travel to DebConf today and will be offline for 24h (or > longer). May be somebody else can check or I'll do that later. You > will finally her from ftpmaster if something is missing. Have a great trip. Hopefully I'll be able to attend DebConf one day :-). > I'd like to repeat that I'm super happy that we have a new active > member in the Debian Med team. :-) > 1. There was a small formatting issue in Files-Excluded stanza of > debian/copyright, I've fixed it in commit a07ede7. Thank you! I made the bad assumption that things would be delimited and separated by a comma. > 2. Files in Files-Excluded are not actually excluded yet: > > E: mmseqs2 source: source-includes-file-in-files-excluded > lib/gzstream/gzstream.h > E: mmseqs2 source: source-includes-file-in-files-excluded > lib/zstd/.buckconfig Surprisingly, I have never seen that within my Lintian. I've ran lintian dozens of times and the only outputs are informational spelling mistakes. This is very strange. My lintian preference has pedantic output disabled. Please let me know how my repackaging attempt went. > 3. 'Zlib-Libpng License' should be written as 'zlib/libpng' in > debian/copyright > > 4. 'GPLv3' should be written as 'GPL-3' in debian/copyright > > 5. License paragraph for 'LGPL' is missing in debian/copyright I also realised I had used an incorrect GPL-3 paragraph, hence I have since rectified this. I'm hoping this is fine now. I'm wondering if there is a better (maybe regex-dependent) way of automatically inserting a dot on a blank line instead of doing this manually. > 6. The built binary package contains a lot of example and test data, > which I'd suggest splitting off to 'mmseqs2-data' or 'mmseqs2-examples'. > I assume most of the users will want 'mmseqs2' only. Agreed. I was fairly hesitant to do this a few days ago - not sure why. However, there are now two packages. I am still working on patching a few more of the remaining test sources. Thank you both for your time and best regards, Shayan Doust On 19/07/2019 12:40, merkys@debian.org wrote: > Hi Shayan, > > On 2019-07-18 18:53, Shayan Doust wrote: >> How far from >> completion would you say I am at this stage? > > The package seems to be in a fair shape, thank you for working on it. > Here are a couple issues I found while reviewing it: > > 1. There was a small formatting issue in Files-Excluded stanza of > debian/copyright, I've fixed it in commit a07ede7. > > 2. Files in Files-Excluded are not actually excluded yet: > > E: mmseqs2 source: source-includes-file-in-files-excluded > lib/gzstream/gzstream.h > E: mmseqs2 source: source-includes-file-in-files-excluded > lib/zstd/.buckconfig > ... > > Thus you have to repackage the source. I do it quite often, and I always > use this link [1] as a reference. Sometimes I don't manage to do it in > single try, luckily, we can always revert unpushed commits :) Let me > know should you need any assistance with this. > > 3. 'Zlib-Libpng License' should be written as 'zlib/libpng' in > debian/copyright > > 4. 'GPLv3' should be written as 'GPL-3' in debian/copyright > > 5. License paragraph for 'LGPL' is missing in debian/copyright > > 6. The built binary package contains a lot of example and test data, > which I'd suggest splitting off to 'mmseqs2-data' or 'mmseqs2-examples'. > I assume most of the users will want 'mmseqs2' only. > > Best wishes, > Andrius > > [1] https://wiki.debian.org/Javascript/Repacking > >
Attachment:
signature.asc
Description: OpenPGP digital signature