[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#914483: Control: reassign -1 src:gdcm 2.8.7-2

On Sat, Nov 24, 2018 at 03:41:36PM +0100, Mattia Rizzolo wrote:
> > > Gert: you mention you gave up on symbols, but at least in gdcm's
> > > changelog I don't see anything about that.  Had you had troubles
> > > there as well?
> > TBH I never tried with gdcm, I think I started to upload the package
> > when it was already at version 2.4 and I didn't even note that there is
> > a script for the symbols there (which points at 2.2).
> At the same time, libvtkgdcm is much more tidy, so at least I will start
> adding a .symbols file to that one...

I've now uploaded a version to experimental with a .symbols file for
libvtkgdcm2.8 only, to check that the symbols don't vary further across

The only differences I notice between amd64 and i386 are that some
vtk-related functions change from long long on amd64 to int in i386.

I pushed everything to git, including my proposal to rename the package
to a wip branch, which I'll upload tomorrow if the builds in
experimental are alright (hopefully I'll get some ftp-master to
fast-track it as well).

Gert: I notice several tags are missing in the gdcm repository, could
you push them?

> > > What I would welcome your help with is explaining the camitk FTBFS on
> > > i386.
> > Just had as peek, my guess is that this will help: 
> > 
> > ifeq ($(DEB_BUILD_ARCH),i386)
> Note that here you probably meant DEB_HOST_ARCH, not build arch.
> >   export DEB_CXXFLAGS_MAINT_APPEND=-ffloat-store
> > endif
> > 
> > The same was needed for ITK because they write tests with floating
> > point values apparently comparing with high accuracy, and on i386
> > optimizations can lead to the used of intermediate 80 bit floating
> > point values that then result in test failures because the references
> > were tuned for 64 bit floating point values. Adding above flag makes
> > sure that intermediate results are not keps in these 80 bit FPU
> > registers.
> ACK, thanks.

                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature

Reply to: