[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: CI for python-cogent



Hi Nadiya,

On Fri, Jun 16, 2017 at 12:05:02AM -0700, Nadiya Sitdykova wrote:
> 1) python-cogent package has script run_tests for testing. But when it runs
> test during the build (what i found in debian/rules), it runs all tests,
> except "KNOWN_TO_FAIL". I added autopkgtest test-suite which also runs all
> tests except those "known to fail" and it works fine.

Sounds sensible.
 
> Should I investigate tests which are known to fail? Or create a patch to
> README, where users advised to use run_tests without mention that some
> tests will fail and it's known?

I had some discussion with upstream that there will be a new version of
pycogent which will be very different.  They considered the current test
suite as obsolete and will not fix any bugs any more - so if we try to
spent a severe amount of time into it, this would probably a waste of
time.  That's the reason I simply used the wimpy approach to just ignore
those tests that failed.

> I investigated this issue and found out that it was happening because I run
> the script under user without rights to create files in /tmp/ directory. So
> after adding rights all tests worked.

Hmmm, this does not sound like a default setting so normal users should
not be affected, right?  Or is pycogent just ignoring $TMP variable
setting and is forcing /tmp as temporary directory?  If this could be
fixed in a **simple** patch it might be worth fixing.

> I added some lines how to overcome this problem to debian/README.test

Sounds sufficient to me in case a patch as I suggested above would be to
time consuming.

BTW, I'm currently run a script to migrate python-cogent from SVN to
Git.  I'll upload with this change once the script has finished.

Thanks for working on this

     Andreas.

-- 
http://fam-tille.de


Reply to: