Re: Is there a reason why multi-threading is disabled in last-align ?
Hi Charles,
On Mon, Jun 12, 2017 at 03:19:21PM +0900, Charles Plessy wrote:
> In last-align, the upstream CXXFLAGS are overwriten by our build system, and therefore
> some flags are re-added in debian/rules:
>
> CXXFLAGS += -Wall -Wextra -Wcast-qual -Wswitch-enum -Wundef -Wcast-align -Wno-long-long -ansi -pedantic -std=c++11
^^
Hmmm, shouldn't these flags only be added to the original CXXFLAGS?
> Unfortunately, the -DHAS_CXX_THREADS flag is not there, either by omission, or
> because it was not there when debian/rules was written, or was there a resason
> to ensure that the program is not built with it for Debian ?
While `git blame debian/rules` blames Julien Lamy for the change and the
according changelog entry says:
[ Julien Lamy ]
* debian/rules:
- Add missing build flags
I do not think that the intention was to drop any flag that should be
set. I have not checked a build log whether something might be messed
up with existing flags and I'd recommend to do so.
> If not, I will add it back (probably via CPPFLAGS, since in my understanding
> it is a preprocessor flag).
>
> By the way, the -pthread CXXFLAGS is repalced by a -lpthread LDFLAG: are both
> equivalent ?
I have no idea and this is the kind of question I usually ask on
debian-mentors list to be sure.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: