[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Outreachy] pymol



Hi Andreas,
I've added copyright information to debian/copyright (for UIUC and various font files from upstream's layer1/).
Can you check it? I've kept UIUC license since it differs in 1st paragraph from BSD-3-clause mentioned at d/copyright.
Also layer1/FontTTF.h has complex license, I copied it as it is.
I've checked everything with cme fix dpkg-copyright.

2016-08-20 13:19 GMT+03:00 merlettaia <merlettaia@gmail.com>:
Hi Andreas,
I've made testsuite for apbs (I took its own tests "(cd tests; python apbs_tester.py -c test_cases.cfg)", installed them to usr/share/apbs, and made sure that they work when installed).
Regarding python interface, which is used by pdb2pqr, it is not present in source archive.
apbs source releases are available on github, but they contain both apbs and pdb2pqr (probably because they both are developed in the same repository)
https://github.com/Electrostatics/apbs-pdb2pqr/releases
On SourceForge there are 2 versions of apbs (1.4.1 and 1.4.2), but they both don't have source archive. Version 1.4.0 is old.
I asked maintainers via gitter channel to add latest apbs source package to SourceForge, let's see if they'll do it.
But probably changing debian/watch to take releases from github might be the option.
I also translated debian/copyright to machine-readable format, but I  haven't checked if something is missing. There are also MAPBS (matlab scripts) inside tools/ directory, they have their own license, but I haven't installed them and haven't checked if their license present in debian/copyright yet.

Regarding pymol, I'll fix debian/copyright now.

2016-08-17 10:57 GMT+03:00 Andreas Tille <andreas@an3as.eu>:
Hi Tanya,

On Tue, Aug 16, 2016 at 08:01:46PM +0300, merlettaia wrote:
> Could you please take a look at pymol?

I did now.  I fixed some minor lintian issues (DEP3, override for
spelling).  I also added some Breaks and a versioned dependency which is
important for upgrades when splitting a package.  Please have a look at
the commits to debian/control which might be an interesting lesson for
other packages.

> I made almost everything possible, except solving this warnings (but I can
> fix them too):
>
>    I: pymol: desktop-entry-lacks-keywords-entry
> usr/share/applications/pymol.desktop

Please just let me know if you want to fix this.

>    W: pymol: command-in-menu-file-and-desktop-file pymol
> usr/share/menu/pymol:7

Fixed by removal of menu file.

Thanks again for your tough work.  I'll upload once I hear from you
about the desktop file.  I'd also upload if you confirm: "Uhhmmm, no
idea what keyword would be appropriate."

Kind regards

       Andreas.

--
http://fam-tille.de



--
Best wishes,
Tanya.



--
Best wishes,
Tanya.

Reply to: