Hi Afif, thanks for your quick review & reply! […] > where the cd $(CURDIR) lines are unnecessary-- every line in the Make > recipe is called in a fresh shell that will already be in the top-level > directory. True. Changed this to the more idiomatic $(MAKE) -C <dir> syntax anyway. > Also, you could override dh_installchangelogs to tell debhelper about > the upstream changelog if it isn't detected automatically. Done. > If the build order doesn't matter, these recursive make invocations can > also be made into separate rules and set as prerequisites of the build. > But that would only help if you're using dh --parallel and probably is > not important. Right. Probably not a major gamechanger in terms of build time, but it’s indeed more elegant and I have adjusted the rules file granularity to do this now. > I'm sorry if you knew these things already and just preferred to do it > the way you did, but I just want to make sure. I can change make these > changes if you'd like. Just let me know. No worries, I’ve just pushed the changes. Feel free to change whatever else catches your eye. Thanks for the helpful hints. Cheers, Sascha
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail