[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [MoM] Re: Help with Debian packaging of DCMTK++



Hi,

Le 22/07/2015 21:07, Andreas Tille a écrit :
> Hi again,
> 
> On Mon, Jul 20, 2015 at 07:03:35PM +0200, Andreas Tille wrote:
>>>
>>> I looked at d-shlibs, but I'm not sure what it is supposed to achieve :
>>> it seems to me that all files are already in place and that they do not
>>> need to be moved in the package. What am I missing?
>>
>> D-shlibs moves the files for you and also respects multiarch and proper
>> file names.  When using d-shlibs you can drop the debian/*.install
>> files. 
> 
> I noticed that you decided to move to d-shlibs in Git.  Seems to
> be convincing. :-)

Yes it is! Although the package requires quite a few overrides, the
overall readability is improved.

> 
> The last thing you need to change in debian/control is:
> 
> $ git diff
> diff --git a/debian/control b/debian/control
> index aaa7533..93683c4 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -29,7 +29,7 @@ Description: Wrappers around DCMTK to have an easier API
>  Package: libdcmtkpp0-dev
>  Architecture: any
>  Section: libdevel
> -Depends: libdcmtkpp0,
> +Depends: libdcmtkpp0 (= ${binary:Version}),
>           ${devlibs:Depends},
>           ${misc:Depends}
>  Provides: libdcmtkpp-dev

Done.

> 
> 
> See the lintian error for an explanation (I guess you were running
> lintian, aren't you?)
> 
> Lintian has also an Information mode.  You might like to check
> 
>    lintian -i -I *.changes

I was indeed running Lintian, but on the .deb and not on the changes. Is
there any advantage of using *.changes instead of *.deb?

Lintian is now error and warning free, and, excluding the typo in the
binary file, the only information left is the no-symbols-control-file:
this one is a bit puzzling to me, is this something I should look into
more closely, or can I let it pass for now and come back to it in later
revisions?

I also submitted the ITP and updated the changelog: the problem I
mentioned earlier concerning reportbug was actually not an issue with my
SMTP configuration, but was related to bugs 789047 and 72226. Should any
one else get bitten by this one before the fix reaches unstable, pulling
the patch from Github [1] works.

I still have to generate a documentation package: I'll try to get this
done early next week…

[1] https://github.com/venthur/python-debianbts/pull/5

Best regards,
-- 
Julien

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: