[MoM] Re: [dwv-orthanc-plugin] 02/02: Buildpackage to use pdebuild.
Hi Yvves,
I checked your commits and found something not so good:
On Sun, Mar 15, 2015 at 10:58:39PM +0000, Yves Martelli wrote:
>
> commit 717fdc371fbf5d414d90665812521fcc65deab20
> Author: ivmartel-guest <ivmartel@gmail.com>
> Date: Sun Mar 15 23:35:56 2015 +0100
>
> Buildpackage to use pdebuild.
> ---
> debian/gbp.conf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/debian/gbp.conf b/debian/gbp.conf
> new file mode 100644
> index 0000000..b63a25d
> --- /dev/null
> +++ b/debian/gbp.conf
> @@ -0,0 +1,2 @@
> +[DEFAULT]
> +builder = ~/bin/git-pbuilder
Here you assume that every other packager has a script
~/bin/git-pbuilder. In the worst case he has `sudo rm -rf /` in this
script. Well, OK anybody who names a script like this deserves the
result but I guess you understand that this is a local setting at your
side and the content belongs rather to your
~/.gbp.conf
than into a packages debian/gbp.conf.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: