[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New package of GWAMA



Hi Dylan,

thanks for your work on this package.

On Tue, Dec 16, 2014 at 08:26:50AM +0100, Dylan wrote:
> Hi all,
> I finished my package of gwama [1]. I put some upstreams examples files
> (which are provides outside the source archive) in debian/upstream.docs/ ,
> I don't know if it's the good way to integrate them.
> 
> Could you check the package and if it's ok, upload it?

I have pushed a minimal change to d/watch which uses the new uscan
option repacksuffix.

Regarding d/copyright:  The patch 02_Fix_license_issue.patch which is
explained in d/README.Debian should be rather explained in d/copyright.
Thorsten (probably partly wearing his ftpmaster hat) was mentioning that
this is suspicious.  The rationale why this text should be rather put
into d/copyright is that it is clearly connected to the copyright
information and this is the file ftpmasters probably inspect first.  It
is not a good idea to split this information (specifically without an
explicit hint inside d/copyright refering to d/README.Debian

If I were you I would add an additional paragraph to d/copyright

Files: commandLine.cpp
Copyright: 2010 Andrew P Morris <amorris@well.ox.ac.uk>
                Reedik Magi <reedik@well.ox.ac.uk>
License: BSD-3-clause
Comment: <content of README.Debian>

or something like this.

Regarding the additional examples:  It is OK to provide them inside
debian/ dir.  I wonder whether you could create a autopkgtest script
using these examples + expected output.

Otherwise the package seems to be ready for upload.

Kind regards

     Andreas.

-- 
http://fam-tille.de


Reply to: