Re: [MoM] Packaging Camp for Debian
Hi Corentin,
On Tue, Sep 09, 2014 at 09:34:24PM +0200, Andreas Tille wrote:
> > In fact, I haven't a lot of things to say in about the package. Can I simply
> > remove this file ?
>
> Sure. Its better to leave out a file than confusing users with incomplete
> information.
Done in Git. :-)
Since I noticed your latest commits I was trying to build again. I
noticed that you have added libboost-all-dev which is a bit lazy since
it pulls in a lot of packages which to my (admittedly poor!!)
understanding is not really needed. So what do you think about this
patch:
diff --git a/debian/control b/debian/control
index 30d5233..458e641 100644
--- a/debian/control
+++ b/debian/control
@@ -4,7 +4,7 @@ Section: science
Priority: optional
Build-Depends: cmake,
debhelper (>= 9),
- libboost-all-dev
+ libboost-dev
Standards-Version: 3.9.5
Vcs-Browser: https://anonscm.debian.org/cgit/debian-med/camp.git
Vcs-Git: git://anonscm.debian.org/debian-med/camp.git
The package builds fine and I have checked that all needed header files
I checked via
grep -Ri boost | grep include | sed 's/^.*:#/#/' | grep '^#' | sort | uniq
are contained in libboost-dev. Since the build log says:
-- Boost version: 1.55.0
I think the needed files are provided even by this way more restricted
Build-Dependency. In case it turns out that simply having the basic
header files is sufficient without any restriction to functionality or
performance we should apply the patch.
I noticed the following additional things:
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE).
I'm not sure whether we should provide development documentation for the
package. If you consider camp as a plain precondition for your final
target that's perfectly fine. We can wait for a bug report (as always
prefered with patch :-)) until a libcamp-dev user might request the
packaging of the docs. I just want to inform you that there might be
some room for improvement later.
I'm a bit more concerned that the test suite is not executed. The file
cmake/Config.cmake contains:
if(NOT BUILD_TEST)
set(BUILD_TEST FALSE
CACHE BOOL "TRUE to build the unit tests (requires the Boost Test Library), FALSE otherwise."
)
endif()
and thus I also added libboost-test-dev to the Build-Depends leading to
$ git diff debian/control
diff --git a/debian/control b/debian/control
index 30d5233..e09d5b3 100644
--- a/debian/control
+++ b/debian/control
@@ -4,7 +4,8 @@ Section: science
Priority: optional
Build-Depends: cmake,
debhelper (>= 9),
- libboost-all-dev
+ libboost-dev,
+ libboost-test-dev
Standards-Version: 3.9.5
Vcs-Browser: https://anonscm.debian.org/cgit/debian-med/camp.git
Vcs-Git: git://anonscm.debian.org/debian-med/camp.git
and since this did not really changed anything
$ git diff debian/rules
diff --git a/debian/rules b/debian/rules
index 4067ba0..e4a25da 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,4 +1,6 @@
#!/usr/bin/make -f
+DEB_CMAKE_EXTRA_FLAGS = -DBUILD_TEST=TRUE
+
%:
dh $@
but I admit my cmake knowledge is limited and perhaps some other quirks
might be needed to enforce running the unit tests which is something we
should try to approach in any package. Do you have a better idea to
enforce the testing in dh_auto_test? If not you might like to ask on
debian-mentors@lists.debian.org since my personal ideas went out after
these unsuccessful tries.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: