> Many thanks for working on this. I can confirm the package builds but has > some lintian issues. Ah... Oh yes I forgot to add the lintian param. > $ lintian libquazip_0.6.2-1_amd64.changes > I: libquazip source: duplicate-short-description libquazip1 libquazip1-qt5 > I: libquazip source: duplicate-short-description libquazip1-dev libquazip1-qt5-dev > I: libquazip source: duplicate-short-description libquazip1-dbg libquazip1-qt5-dbg Ahhhhh yes I forgot the 'short' description ! > These infos are easily to be solved by just explaining the Qt4/Qt5 > difference in an additional paragraph. Regarding the naming: I admit I > have no experience with Qt libraries but from my naive point of view it > would make sense to use libquazip1-qt4 instead of libquazip1, > libquazip1-qt4-dev instead of libquazip1-dev and as well for the -dbg > package. Please forget my hint in case other libraries also do not > include qt4 in the package name and take this as default. Well, mentors told me that Qt4 is the default Debian version. So packages should not have to marked with -qt4 in opposition with -qt5 package. But you are right, I should ask twice ;) > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/JlCompress.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/crypt.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/ioapi.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quaadler32.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quachecksum32.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quacrc32.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quagzipfile.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quaziodevice.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quazip.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quazip_global.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quazipdir.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quazipfile.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quazipfileinfo.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/quazipnewinfo.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/unzip.h > W: libquazip source: binaries-have-file-conflict libquazip1-dev libquazip1-qt5-dev usr/include/quazip/zip.h > > I think this can be solved either by a conflicts between these two > packages if the header files are really different or if they are equal > it might make sense to provide a libquazip1-headers file containing the > common headers and let both -dev packages depend from it. Ok I've already thought about this option. I've added such a package and will test the build tonight. > I: libquazip1: no-symbols-control-file usr/lib/x86_64-linux-gnu/libquazip.so.1.0.0 > > Please ignore or override this. To my experience in such low popcon > packages symbols control files always have the purpose to put > maintenance work on you and are not really needed. Ok, since I have this file, from the upstream, I'll try to include it. > W: libquazip1-qt5-dbg: empty-binary-package > > You said you wold work on this ... OK. Ah ah ! Yes, you're right. > W: libquazip1-qt5: package-name-doesnt-match-sonames libquazip-qt5-1 > > I guess this is hard to fullfill. For the moment I would ignore it or > ask on debian-mentors list how to copy with this. I personally do not > have any clue. > > I: libquazip1-qt5: no-symbols-control-file usr/lib/x86_64-linux-gnu/libquazip-qt5.so.1.0.0 > > See above (ignore or override). > > W: libquazip1-dbg: empty-binary-package > > Feel free to ask here if you need further hints for the -dbg package(s). The draft code is already included in the debian/rules, thanks. When I ask you for a review, I know that I will still have some/a-lot-of work to do ;) Thank you Andreas for your (always) pertinent review ;) Eric
Attachment:
signature.asc
Description: OpenPGP digital signature