Re: cufflinks package is ready for upload
Le Sat, Dec 10, 2011 at 01:44:30PM +0100, Alex Mestiashvili a écrit :
> On 12/10/2011 01:13 PM, Charles Plessy wrote:
> >
> > I had a look at cufflinks, and I think it can be uploaded to non-free.
> >
> > The only issue I found is that it ignores the CFLAGS passed by
> > dpkg-buildpackage and dpkg-buildflags.
> >
> Thank you for taking care of it .
> I wonder how you noticed that flags are not passed ?
> And how can I see that ?
As a rule of thumb, if the build logs show the binaries built with -O3, it
means that the CFLAGS are ignored, as they pass -O2 and other flags.
Moreover, the absence of the Dpkg buildflags is also easy to spot, as some of
them related to hardening are not yet widespread in upstream makefiles.
In the case of cufflinks, switching to Debhelpers' compatibility level 9
solves this problem. For other packages, it may not be enough.
Perhaps unsurprisingly, once the dpkg-buildflags are passed, cufflinks fails
to build, because of its oldest component, locfit.
gcc -DHAVE_CONFIG_H -I. -I.. -I../src -D_FORTIFY_SOURCE=2 -I/usr/include -Wall -Wno-strict-aliasing -g -gdwarf-2 -Wuninitialized -m64 -O3 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -DNDEBUG -c -o makecmd.o `test -f 'locfit/makecmd.c' || echo './'`locfit/makecmd.c
locfit/makecmd.c: In function 'makefields':
locfit/makecmd.c:88:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
locfit/makecmd.c: In function 'makecmd':
locfit/makecmd.c:203:3: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors
make[3]: *** [makecmd.o] Error 1
make[3]: Leaving directory `/«PKGBUILDDIR»/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/«PKGBUILDDIR»'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/«PKGBUILDDIR»'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
It is a bit late so I will not upload this night, but if nobody sends a patch
until tomorrow morning, I will upload the package as it is. Let's ask Upstream
to replace locfit, which is also the cause for cufflinks to be non-free, and
turn the dpkg-buildflags on later.
Cheers,
--
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan
Reply to: