Re: vienna-rna is almost ready

[Manuel Prinz <manuel@debian.org>]

Hi Alex!

On Thu, Feb 03, 2011 at 05:04:34PM +0100, Alex Mestiashvili wrote:
> What else should be done to process this package ?

Sorry for replying late! I had a quick look at your package. It's
looks very good given that you just started to learn how to package!
There are a few glitches which you should address. I'll sponsor the
package once these are fixed.

 - As I understand it, RNAforester is shipped with ViennaRNA but
   since it's only one binary it's shiped in the vienna-rna package.
   I think you should mention that in the long description of the
   package, so users looking for RNAforester can find the right
   package to install.

 - Please remove the index lines and timestamps of the patches. They
   make commit diffs harder to read and add no value. You can do
   this by applying a patch and call
     quilt refresh -p ab --no-timestamps --no-index
   for each patch. You might want to include those into your .quiltrc.

 - Please add DEP3 headers [1] to the patches. This helps others to
   gain information about the patch status. (What does it do? Was it
   forwarded to upstream?) This is especially important in patch file
   naview_copyright.patch, as it requires permission of upstream.
   (Which you have, in this case. But ftp-masters want to know.)

 - You should be able to solve the configure-generated-file-in-source
   lintian warnings by using "dh --with autotools_dev $@" in rules.
   See "man 1 dh_autotools-dev_restoreconfig" for more information.

 - The manpage-has-errors-from-man lintian tags should be solved as
   well, though this is not crutial.

 - The patches for using the local libg2 are just workarounds. This
   is OK as of now but you should talk to upstream about providing
   a mechanism to do so directly via configure.

 - The first lines in debian/rules could be updated.

That's all for now. The rules file looks more complicated than it
might need to be but I'll look at it in detail, as I can't build
the package at the moment. I'll also need to check the copyright,
as I have not done that properly. (Just had a quick glance, looks
good.)

Please address the above points. You can reply to me in private when
you have updated the package. If you have questions, please feel free
to ask on the list (or mail me privately).

Thanks for your work on the package!

Best regards,
Manuel

[1] http://dep.debian.net/deps/dep3/