Il giorno Wed, 30 Jan 2008 20:37:50 +0900 Charles Plessy <charles-debian-nospam@plessy.org> ha scritto: > Hi David, Hi Charles, > just a few comments: > > Le Wed, Jan 30, 2008 at 10:54:18AM +0000, hanska-guest@alioth.debian.org a > écrit : > > > +DB2MAN=/usr/share/sgml/docbook/stylesheet/xsl/nwalsh/\ > > +manpages/docbook.xsl > > +XP=xsltproc -''-nonet > > + > > +manpage.1: manpage.dbk > > + $(XP) $(DB2MAN) $< > > You do not need $(DB2MAN) anymore since the xsl stylesheet is declared > at lines 2 & 3. Well, that's a comment :) I'll drop it completely. > > Added: trunk/packages/axparafit/trunk/debian/axparafitblas.1 > > =================================================================== > > --- > > trunk/packages/axparafit/trunk/debian/axparafitblas.1 > > (rev 0) +++ trunk/packages/axparafit/trunk/debian/axparafitblas.1 > > 2008-01-30 10:54:18 UTC (rev 1219) @@ -0,0 +1 @@ +.so man1/axparafit.1 > > The Debian Policy §12.1 recommends to use symlinks anyway (but > dh_installman takes care of doing this). Well, not really. Those "fake" manpages are generated by `xsltproc <...>`. I'll try to achieve that with symlinks, but it's hacky to me (i.e. xsltproc generates .1 files, we delete them and then symlink?!). > Unless you need a feature of Debhelper 6, I recommend to keep 5 until > Etch support is dropped: this facilitates home-made backports (I think > that backports.org provides an up-to-date debhelper environment). You're right here, sorry. > > +Build-Depends: debhelper (>= 6), quilt, > > + refblas3-dev, atlas3-base-dev, libmpich1.0-dev > ... > > +Files: debian/* > > +Copyright: © 2008, David Paleino <d.paleino@gmail.com> > > +License: GPL-3+ > > I am not completely sure, but maybe it is required that the libraries > axparafit is built upon are compatible with GPLv3 if you use this for > the packaging scripts. I would recommend checking or downgrading. > (Usually, I like to use a "same as $(packaged program) license"). Ehm... what? Are you sure? I'll ask on debian-legal. > > Added: trunk/packages/axparafit/trunk/debian/dirs > > =================================================================== > > --- > > trunk/packages/axparafit/trunk/debian/dirs > > (rev 0) +++ trunk/packages/axparafit/trunk/debian/dirs 2008-01-30 > > 10:54:18 UTC (rev 1219) @@ -0,0 +1,2 @@ +usr/bin > > +usr/share/man/man1 > > debian/dirs does not seem to be required. Uhm. Right, we can call dh_installdirs usr/bin. > > +XP=xsltproc -o debian/ -''-nonet > > The two apostrophes are not necessary in debian/rules (only in the XML > source) Do you mean: XP=xsltproc -o debian/ -nonet ? Kindly, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 ----|---- http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
Attachment:
signature.asc
Description: PGP signature