[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Review and testing phpmyadmin for Jessie LTS



Hi Lucas,

Sorry for the late answer.

I had an issue with your patch and took a while to find out what was going
wrong.

This update broke table creation...

> +--- a/libraries/transformations.lib.php
> ++++ b/libraries/transformations.lib.php
> +@@ -145,9 +145,10 @@ function PMA_getTransformationDescriptio
> +     $class_name = explode(".class.php", $file);
> +     $class_name = $class_name[0];
> + 
> +-    // include and instantiate the class
> +-    include_once 'libraries/plugins/transformations/' . $file;
> +-    return $class_name::getInfo();
> ++    if (class_exists($class_name)) {
> ++        return $class_name::getInfo();
> ++    }
> ++    return ''

I guess a ; is missing here :)

cheers,

Hugo

-- 
                Hugo Lefeuvre (hle)    |    www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C

Attachment: signature.asc
Description: PGP signature


Reply to: