Re: Review and testing phpmyadmin for Jessie LTS

[Lucas Kanashiro <kanashiro@riseup.net>]

Hi Hugo,

On 1/28/19 6:40 AM, Hugo Lefeuvre wrote:
> Hi Lucas,
>
> Sorry for the late answer.
Do not worry.
> I had an issue with your patch and took a while to find out what was going
> wrong.
>
> This update broke table creation...
>
>> +--- a/libraries/transformations.lib.php
>> ++++ b/libraries/transformations.lib.php
>> +@@ -145,9 +145,10 @@ function PMA_getTransformationDescriptio
>> +     $class_name = explode(".class.php", $file);
>> +     $class_name = $class_name[0];
>> + 
>> +-    // include and instantiate the class
>> +-    include_once 'libraries/plugins/transformations/' . $file;
>> +-    return $class_name::getInfo();
>> ++    if (class_exists($class_name)) {
>> ++        return $class_name::getInfo();
>> ++    }
>> ++    return ''
> I guess a ; is missing here :)

Great, sorry for being a victim of my lack of attention... I've never
used phpmyadmin (that's why I requested some testing) and my local tests
were so basic that they didn't catch this issue. Shame on me.

I'll fix it and perform some tests. Thanks for the review and the time
that you spent on this.

Cheers!

-- 
Lucas Kanashiro