[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Snapshot problems!!!



On Thu, Nov 26, 2009 at 09:49:51AM +0100, Marco Amadori wrote:
> 
> I introduced the regression while fixing another feature, I must learn that 
> there are no such thing like "small refactoring" without testing, my apologize 
> to all.
> 
> This patch will fix the problem:
> 
> diff --git a/bin/live-snapshot b/bin/live-snapshot
> index 18b067b..55673bb 100755
> --- a/bin/live-snapshot
> +++ b/bin/live-snapshot
> @@ -443,10 +443,10 @@ Do_snapshot ()
>                                         grep -F -v -f "${EXCLUDE_LIST}" | \
>                                         tr '\n' '\0' | \
>                                         tr '\1' '\n' | \
> -                                       $COPY_CMD || exit 1
> +                                       eval $COPY_CMD || exit 1
>                         else
>                                 cat "${TMP_FILELIST}" | \
> -                                       $COPY_CMD || exit 1
> +                                       eval $COPY_CMD || exit 1
>                         fi
>                         cd "${OLDPWD}"
>                         ;;
> 
Thanks.  The patch worked properly when applied to the latest version in
the Debian repos.  But due to my inexperience, I had to type the patch
manually.  What would the proper command have been to apply the patch
the correct way?

Feature request:  It would be nice to see some notification that the USB
is being "sync'd" on shutdown/reboot.  My USB device doesn't have a
light, so it appears that my system is hung for several moments, until
writing to the USB is complete.

-Rob


Reply to: