[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#834370: lintian: c/debhelper.pm: Correct false positive in matching targets with extra whitespace



* Chris Lamb <lamby@debian.org>, 2016-08-15, 12:14:
-        } elsif (/^override_(dh_[^:]+)/) {
+        } elsif (/^override_dh_.*:/) {

Not a regression (and I fear other parts of Lintian might be doing this wrong, too...), but to be pedantically correct:
- we should allow leading spaces;
- we should allow combining overrides and non-overrides on the same line, e.g.:

foo bar override_dh_baz:
	...

+            while (/override_(dh_[^\s:]+)\s*/g) {

This regexp is too lax. For example, it has 3 matches for this (real-world) line:

override_dh_prep: quantum_override_dh_prep_Q16 quantum_override_dh_prep_indep

--
Jakub Wilk


Reply to: