Bug#834370: lintian: c/debhelper.pm: Correct false positive in matching targets with extra whitespace
Package: lintian
Version: 2.5.46
Severity: wishlist
Tags: patch
Hi,
Attached is the following:
commit 6e3872259986db25c60a6a5bf158c9dd35e28a7b
Author: Chris Lamb <lamby@debian.org>
Date: Mon Aug 15 00:18:39 2016 +0100
c/debhelper.pm: Correct false positive in matching targets with extra whitespace.
checks/debhelper.pm | 2 +-
t/tests/debhelper-override-typos/debian/debian/rules | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
From 6e3872259986db25c60a6a5bf158c9dd35e28a7b Mon Sep 17 00:00:00 2001
From: Chris Lamb <lamby@debian.org>
Date: Mon, 15 Aug 2016 00:18:39 +0100
Subject: [PATCH] c/debhelper.pm: Correct false positive in matching targets
with extra whitespace.
---
checks/debhelper.pm | 2 +-
t/tests/debhelper-override-typos/debian/debian/rules | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/checks/debhelper.pm b/checks/debhelper.pm
index 3883033..2e0cead 100644
--- a/checks/debhelper.pm
+++ b/checks/debhelper.pm
@@ -178,7 +178,7 @@ sub run {
$dhcompatvalue = $1;
# one can export and then set the value:
$level = $1 if ($level);
- } elsif (/^override_(dh_[^:]+)/) {
+ } elsif (/^override_(dh_[^\s:]+):/) {
$needbuilddepends = 1;
my $dhcommand = $1;
if (not $dh_commands_depends->known($dhcommand)) {
diff --git a/t/tests/debhelper-override-typos/debian/debian/rules b/t/tests/debhelper-override-typos/debian/debian/rules
index 975c83a..0674f2e 100755
--- a/t/tests/debhelper-override-typos/debian/debian/rules
+++ b/t/tests/debhelper-override-typos/debian/debian/rules
@@ -4,7 +4,7 @@
dh $@
# Good
-override_dh_install:
+override_dh_install :
override_dh_will_never_exist:
# Bad
--
2.8.1
Reply to: