[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#834370: lintian: c/debhelper.pm: Correct false positive in matching targets with extra whitespace



Chris Lamb:
> Package: lintian
> Version: 2.5.46
> Severity: wishlist
> Tags: patch
> 
> Hi,
> 
> Attached is the following:
> 
>   commit 6e3872259986db25c60a6a5bf158c9dd35e28a7b
>   Author: Chris Lamb <lamby@debian.org>
>   Date:   Mon Aug 15 00:18:39 2016 +0100
>   
>       c/debhelper.pm: Correct false positive in matching targets with extra whitespace.
>   
>    checks/debhelper.pm                                  | 2 +-
>    t/tests/debhelper-override-typos/debian/debian/rules | 2 +-
>    2 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> Regards,
> 

Hi,

Thanks for working on this. :)

This makes me wonder if:

  # Skip these
  override_dh_foo override_dh_bar:

work as intended[1]. From a quick glance, it looks like our code only
validates the first override in a single line.

Thanks,
~Niels

[1] Examples include:
https://anonscm.debian.org/git/debhelper/debhelper.git/tree/debian/rules


Reply to: