Re: [RFC] Replacing Lintian::Relation::Version
"Adam D. Barratt" <adam@adam-barratt.org.uk> writes:
> I've been looking at replacing the current implementation of
> Lintian::Relation::Version with a shim around libapt-pkg-perl.
Oh, thank you! I've been wanting to do that for a while and kept not
finding the time.
> I believe the attached does what we need, but have a niggling feeling
> I've missed something, as it seemed too easy. :-)
No, this should be all there is to it. :)
> I've plumped for using libapt-pkg-perl (as suggested in the TODO item)
> rather than Dpkg::Version (as suggested by the comments in the
> original module) as it should be more efficient, which is the object
> of the exercise after all. The only downside I can see is that it's
> an additional dependency, but I don't think that's a huge issue - it's
> not a particularly large package and its only dependencies are
> basically guaranteed to be present already (perl, apt, libgcc1,
> libstdc++6).
Yeah, it should be fine (although one of us should open an RT ticket
asking for it to be installed on gluck, since it isn't currently).
I looked it over and it looks great, although could you also add a test
case to t/scripts? Should be a pretty easy one to do with Test::More.
Thank you very much for doing this!
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: