[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Many bug fixes, more tests, and unimplemented tags



Raphael Geissert <atomo64+debian@gmail.com> writes:

> While writting some tests for lintian's internals I noticed that there
> are many unimplemented tags, i.e. there's a tag description and all in
> the .desc file but the check script never mentions the given tag.

There probably are some, but you also have false positives here from
places where variables are used to form the tag names.  For example, all
of these do exist:

> #   Unimplemented tag 'maintainer-name-missing' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'maintainer-address-missing' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'maintainer-address-malformed' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'maintainer-not-full-name' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'maintainer-address-looks-weird' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'maintainer-address-is-on-localhost' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'uploader-name-missing' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'uploader-address-missing' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'uploader-address-malformed' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'uploader-not-full-name' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'uploader-address-looks-weird' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc
> #   Unimplemented tag 'uploader-address-is-on-localhost' detected
> #   at /home/raphael/Deb/lintian/checks/fields.desc

I suspect there are a lot of others in that camp from this scan.  Maybe do
something to turn variables in tag calls into regexes similar to what you
did with diversions?

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>


Reply to: