Re: [RFC/PATCH] New Lintian::Output module
On Sat, Sep 20, 2008 at 01:57:45PM +0200, Frank Lichtenheld wrote:
> A patch series to bundle all the output logic of lintian into
> modules and to make it easier to define new output formats.
>
> Comments welcome.
Good. I think it is better than the current way of doing it, just a few
comments:
Isn't it a bit confusing that verbose messages are printed using "v_msg"
while debug messages use "debug_msg"? On the other hand, verbose is a
subset of debug, and I'm not sure if there is any reason to keep them
apart. I mean, perhaps it would make sense to have a single subroutine
and convert verbose messages to level 0 debug messages (only printed if
--verbose is enabled).
One of the outputs I thought about involved printing after processing
the packages instead of printing as tags are found. How would you
implement it with the new interface? I guess it shouldn't be a problem
to add a flush() method to print remaining tags. There is probably no
need to add it at the moment since current outputs do not require it,
just wanted to know what do you think about it.
(Btw, I haven't been very active lately, but I'm still alive. Just had a
lot of other stuff to do here and there. I still plan to continue
contributing to lintian.)
Reply to: