Re: [RFC/PATCH] New Lintian::Output module
On Sun, Sep 21, 2008 at 05:58:27PM +0200, Jordà Polo wrote:
> On Sat, Sep 20, 2008 at 01:57:45PM +0200, Frank Lichtenheld wrote:
> > A patch series to bundle all the output logic of lintian into
> > modules and to make it easier to define new output formats.
> >
> > Comments welcome.
>
> Good. I think it is better than the current way of doing it, just a few
> comments:
>
> Isn't it a bit confusing that verbose messages are printed using "v_msg"
> while debug messages use "debug_msg"? On the other hand, verbose is a
> subset of debug, and I'm not sure if there is any reason to keep them
> apart. I mean, perhaps it would make sense to have a single subroutine
> and convert verbose messages to level 0 debug messages (only printed if
> --verbose is enabled).
Will think about that.
> One of the outputs I thought about involved printing after processing
> the packages instead of printing as tags are found. How would you
> implement it with the new interface? I guess it shouldn't be a problem
> to add a flush() method to print remaining tags. There is probably no
> need to add it at the moment since current outputs do not require it,
> just wanted to know what do you think about it.
Storing the tag information in the object instead of printing it should
be no problem for a subclass. And adding a hook at the start and end
of each package and each check is something that was on my mind, too
(I don't know what output you're thinking of, but it would certainly
make it e.g. easier to create a useful XML output).
So if you want to propose some patches in that direction, they would
certainly be welcome.
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: